• erikchen's avatar
    macOS: Fix [cmd + left arrow] not working in Omnibox. · 4c9d0845
    erikchen authored
    After a recent refactor, [cmd + left arrow] would perform history navigation
    instead of moving the cursor to the beginning of the Omnibox. This happens
    because the processing for the hotkey [triggering history navigation] has higher
    priority than the typical event handling flow.
    
    The hotkeys [cmd + left arrow] and [cmd + right arrow] are special, and should
    only trigger if the firstResponder is a WebContents, and the WebContents has
    chosen not to process the event.
    
    This CL removes handleExtraKeyboardShortcut:, which was dead code.
    
    Bug: 852332
    Change-Id: Id03f5e22337a79d9ca4abfd20d995a8cf8976b2a
    Reviewed-on: https://chromium-review.googlesource.com/1099648Reviewed-by: default avatarNico Weber <thakis@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#567315}
    4c9d0845
command_dispatcher.mm 9.45 KB