• Oystein Eftevaag's avatar
    Tracing: Removed DCHECK for trace buffer size change in TraceConfig merges · 4cf67d84
    Oystein Eftevaag authored
    This setting is only used by Perfetto, which doesn't merge configs.
    
    With this DCHECK in place, the trace buffer size can't be configured
    through Telemetry as the setting isn't passed through any
    command-line switches and hence the DCHECK is hit when the full
    config is passed through the full Mojo path and merged with the
    startup tracing one. As the option is only used within the tracing
    service after startup tracing has already been set up, there's
    no point in passing it through the command line and so we just
    ignore it instead, if it changes.
    
    
    R=ssid@chromium.org
    
    Bug: 946517
    Change-Id: I56d05dd4f7167dfada4560737d054132d0a47dc4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548372Reviewed-by: default avatarssid <ssid@chromium.org>
    Commit-Queue: oysteine <oysteine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#646617}
    4cf67d84
trace_config.cc 23.2 KB