• Hazem Ashmawy's avatar
    [AW] DevUI: Polish WebView crash UI · 4d006cbf
    Hazem Ashmawy authored
    Polish WebView crash UI layout:
    - Use android material theme and support dark theme.
    - Use an expandable list to show crashes where we show the important
      info (package name and crash capture time in the header) and show
      variation keys, upload status, report button in the expanded body.
    - Use a more descriptive string for the reporting button
      "File bug report" instead of "Provide more info".
    - For better visualization, show app icon next to package name to
      be easy to find by eye.
    - Use ListViewAdapter#notifyDataSetChanged() instead of creating
      new adapter to optimize crash list updates.
    - Update MainActivity to use the new two_line_list_item layout.
    
    Bug: 948923
    Test: Manually inspect the UI on SystemWebView on Android P and Android Q with dark mode switched on/off.
    Change-Id: Ic9d4fffc6f24a409f06927b91b160280c5781e7b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899371
    Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
    Reviewed-by: default avatarRichard Coles <torne@chromium.org>
    Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#713623}
    4d006cbf
BUILD.gn 5.17 KB