GitLab

A recent change made to enable is_multi_dll_chrome = false caused a
regression for component builds where the crash export thunks were
getting linked into chrome.dll instead of chrome_elf. Chrome.dll pulls
in headless_shell_lib which on Windows depends on crash_export_thunks.
This has the side-effect of statically linking these thunks into
chrome.dll instead of having them be imported from chrome_elf.dll. The
result of which is that the crash report database in chrome_elf.dll is
never initialized. The bug only impacts component builds where
is_multi_dll_chrome is set to false.

Regression caused by: http://crrev.com/c/1697368

Bug: 991886
Change-Id: I1170544da9842fc503cc48ffd2cc07f5023a4240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742400Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Chris Davis <chrdavis@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#686322}