• Josh Nohle's avatar
    [Nearby] Filter out unreachable contacts · 4d6b9b15
    Josh Nohle authored
    In cl/339905938, the Nearby server started returning both reachable
    and unreachable contacts in the ListContactPeople RPC response. The
    ContactRecord proto message now has a field denoting the contact's
    reachability.
    
    In this CL, we filter out unreachable contacts, counting the number
    of removed unreachable contacts. This count is communicated to
    observers. It may be useful to inform the user in the contacts UI that
    a certain number of contacts are not being shown because they are not
    associated with a GAIA account, and that Nearby Share requires this
    association. This information is already present in the Android Nearby
    Share UI.
    
    Note: This CL should not be submitted until cl/339905938 reaches prod;
    otherwise, all contacts will be filtered out due to the default-false
    |is_reachable| field. After cl/339905938 hits prod but before this CL
    lands, unreachable contacts will not be filtered out.
    
    Bug: 1143837
    Change-Id: I439469e02e9694e5853c807928dd687eaf7f3f69
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514176Reviewed-by: default avatarJames Vecore <vecore@google.com>
    Reviewed-by: default avatarAlex Gough <ajgo@chromium.org>
    Commit-Queue: Josh Nohle <nohle@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#823749}
    4d6b9b15
rpc_resources.proto 4.64 KB