GitLab

This is part of a larger cleanup effort of the Chrome cookie codebase
with the long term goal of making the CanonicalCookie constructor
private.

The cookie manager code checks whether the serialized/deserealized
cookie is valid, and since this code is a security boundary we think
this check is worth keeping with test coverage.

In order to do so, we need to remove the DCHECK in

that relied on the check we are removing.

CanonicalCookie: :FromStorage and include new checks at the callsites
Bug: 1102874
Change-Id: I9c9436827d668042ba41229ce8819ef925cb5d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490242Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#820347}