• David Benjamin's avatar
    Remove SSLConfig::false_start_enabled · 4e0215d0
    David Benjamin authored
    It is now only set in tests, where it is a largely a no-op because False
    Start since acquired an ALPN requirement. When False Start is triggered,
    we do need to worry about post-Connect() handshake data and sessions
    being established late, but TLS 1.3 has the same problem unavoidably.
    
    Abstract the ticket-forcing logic behind a new helper so we can easily
    add it as needed in the future.
    
    (Firefox actually no longer requires ALPN for False Start. This may be
    worth considering, in which case we may need to revisit some more of
    these tests. Additionally, SpawnedTestServer doesn't support TLS 1.3 and
    most of these tests haven't moved to EmbeddedTestServer, which may also
    require fixing up tests.)
    
    Bug: none
    Change-Id: I444ee12b66aed88898d1492ee0df29817c155348
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708675
    Auto-Submit: David Benjamin <davidben@chromium.org>
    Reviewed-by: default avatarSteven Valdez <svaldez@chromium.org>
    Commit-Queue: David Benjamin <davidben@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#686506}
    4e0215d0
ssl_client_socket_unittest.cc 221 KB