• Ian Vollick's avatar
    [vr] Switch to exclusive visibility checks in the UI unittests · 4face974
    Ian Vollick authored
    Previously, there were many spots in the UI unittests where we checked
    that a set of UI elements (and only that set of UI elements) was
    visible. This had regressed, however, and in the interim, elements had
    been added that were not accounted for in the test expectations.
    
    In this CL, I have switched back to exclusive visibility checks, and
    have updated the appropriate expectations. I have also introduced the
    notion of an owner elements. This both permits unit tests to refer to
    unnamed sub-elements meaningfully and allows for better debug output
    (the hierarchy dumps are much more meaningful).
    
    This also permitted including these unnamed sub-elements in the
    stacking unit test. I have also moved the remaining stacking unit
    tests into the UI unittests.
    
    I have also updated the backplane click test to simulate the response
    to the click so we can check that the visuals update as we expect.
    
    Bug: 782395
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Change-Id: I8f4f0fb92df18dc6b8d7a8e086768d4a97136898
    Reviewed-on: https://chromium-review.googlesource.com/789440
    Commit-Queue: Ian Vollick <vollick@chromium.org>
    Reviewed-by: default avatarChristopher Grant <cjgrant@chromium.org>
    Reviewed-by: default avatarYash Malik <ymalik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#519503}
    4face974
ui_test.cc 8.14 KB