• Yuke Liao's avatar
    Revert "Lacros: create lacros tast test targets" · 501fec5e
    Yuke Liao authored
    This reverts commit e2f3b551.
    
    Reason for revert:
    
    Breaks local user flow when entering chrome_sdk
    
    ERROR at //build/config/chromeos/rules.gni:180:11: Undefined identifier.
              _symlink_targets[2],
              ^-----------------
    See //chromeos/BUILD.gn:239:3: whence it was called.
      generate_runner_script("cros_test_wrapper") {
      ^--------------------------------------------
    See //BUILD.gn:442:7: which caused the file to be included.
          "//chromeos:chromeos_unittests",
    
    Original change's description:
    > Lacros: create lacros tast test targets
    >
    > This CL creates gn targets for lacros tast tests, and the main
    > motivation is to run lacros tast tests on Chromium CI.
    >
    > Bug: 1158590
    > Change-Id: I783779c3386a39743b8227367189b0b87832b9dc
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606188
    > Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
    > Reviewed-by: Ben Pastene <bpastene@chromium.org>
    > Reviewed-by: Dirk Pranke <dpranke@google.com>
    > Cr-Commit-Position: refs/heads/master@{#844127}
    
    TBR=dpranke@google.com,liaoyuke@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    
    Change-Id: I1e51bf2e6aa97bfc40beba7d2693b68361cab2bc
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1158590
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633782Reviewed-by: default avatarYuke Liao <liaoyuke@chromium.org>
    Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#844180}
    501fec5e
rules.gni 9.18 KB