-
pkotwicz@chromium.org authored
Revert of Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (patchset #1 of https://codereview.chromium.org/462083003/) Reason for revert: The CL turns out to be innocent. Reverting the revert Original issue's description: > Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (https://codereview.chromium.org/457003002/) > > Reason for revert: > Speculatively reverting CL in case it is causing WebNavigationApiTest.OpenTab to fail http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=browser_tests&tests=WebNavigationApiTest.OpenTab > > Original issue's description: > > site isolation: cross-site transfers should track the RenderFrameHost, not the View > > > > This fixes some issues that came up while debugging bug 400850, which inadvertently caused OOPIF-like view reuse in RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap. > > > > 1. Make navigation_suspended state be per-RenderFrameHost. What was happening, was that we'd suspend navigations on the non-main frame of the view, and upon resume, we'd switch frames. > > > > 2. Make the map of pending cross site requests be a map of RenderFrameHost IDs instead of RenderViewHost IDs, instead of just assuming that it's the main frame of the view that's navigating. > > > > 3. Add a pending_main_rfh() to the test apparatus, for use by unittests that query the navigation_suspended state. > > > > BUG=304341, 400850 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288867 > > TBR=creis@chromium.org,nick@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=304341, 400850 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289049 TBR=creis@chromium.org,nick@chromium.org NOTREECHECKS=true NOTRY=true BUG=304341, 400850 Review URL: https://codereview.chromium.org/466933003 Cr-Commit-Position: refs/heads/master@{#289082} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289082 0039d316-1c4b-4281-b951-d872f2087c98
50660700
