• Marc Treib's avatar
    Bookmark sync: Use random GUIDs as temporary server IDs · 51be6f11
    Marc Treib authored
    ...instead of the actual GUID of the bookmark node.
    This fixes a crash, see linked bug.
    The problem is that right now, before the GUID-aware merge algorithm is
    rolled out, bookmark GUIDs are not actually guaranteed to be unique.
    This can result in two separate bookmark nodes getting assigned the
    same server ID, resulting in a CHECK() crash.
    
    This is an immediate fix for the crash; longer-term we need to make
    sure that bookmark node GUIDs are actually guaranteed to be unique.
    
    Bug: 1004205
    Change-Id: Ic2e5e17b025b65e0739e6cb82a58053ff11209a9
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864800
    Commit-Queue: Marc Treib <treib@chromium.org>
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Auto-Submit: Marc Treib <treib@chromium.org>
    Reviewed-by: default avatarMohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#706999}
    51be6f11
bookmark_model_observer_impl_unittest.cc 25.6 KB