GitLab

As far as I understand, it was introduced in the past because the
app list UI used to be outside of ash.

As things are currently, this artificial divide creates significant
unnecessary complexity within ash/app_list, with functionality
spread over several classes with semi-ridiculous names (e.g.
app list presenter delegate impl) and a class hierarchy designed
to overcome the divide, and a lot of duplication and passing
information (between the app list controller, the app list presenter,
the app list presenter delegate, each one with its "impl" class)
that slows down development and makes understanding the class
structure difficult.

The historical reasons for this separate namespace are no longer
relevant.

With everything in the "ash" namespace, the next step will be to start
consolidating and reduce over-engineering.

There were a few naming conflicts: with SearchResultType, that was
resolved by renaming one of them to AppListSearchResultType, one with
DialogPlate (one was postfixed with "Deprecated") and another with
AssistantMainView (same resolution).

This contains no semantic change and doesn't have any expected
user-visible implications.

Change-Id: I0755476a1fb7a6f0898258dee6e8981b7358c904
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838269
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704086}