• Fady Samuel's avatar
    Reland "Reland "Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink"" · 51fc7449
    Fady Samuel authored
    This reverts commit 79605d54.
    
    Reason for revert: <INSERT REASONING HERE>
    
    Original change's description:
    > Revert "Reland "Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink""
    > 
    > This reverts commit 79edda64.
    > 
    > Reason for revert: We have branched into M68.
    > 
    > Original change's description:
    > > Reland "Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink"
    > > 
    > > This is a reland of 119455cb
    > > 
    > > Original change's description:
    > > > Surface synchronization: Add a diagnostic CHECK in ClientLayerTreeFrameSink
    > > >
    > > > There's a race in cc somewhere from commit to draw. I don't know exactly
    > > > how to repro the race yet even though I have a high probably fix. This
    > > > CL is intended to catch the race in the wild and produce a stack trace
    > > > in a crash log. Hopefully from there we can acertain repro steps.
    > > >
    > > > Once repo steps are produced locally (either via user interaction or
    > > > unit test) then this CL will be reverted.
    > > >
    > > > Bug: 672962
    > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    > > > Change-Id: I3bce066591e15d5c3aac7d4c8685dce411e284b7
    > > > Reviewed-on: https://chromium-review.googlesource.com/973987
    > > > Reviewed-by: Saman Sami <samans@chromium.org>
    > > > Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#544834}
    > > 
    > > Bug: 672962
    > > TBR: samans@chromium.org
    > > Change-Id: I880540f3f00c419efb4055007787e86f4722d675
    > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    > > Reviewed-on: https://chromium-review.googlesource.com/981154
    > > Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    > > Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#545994}
    > 
    > TBR=fsamuel@chromium.org,samans@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 672962
    > Change-Id: I02cc346dddda60a02e9233ec6fcb7c9df50e1d8a
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    > Reviewed-on: https://chromium-review.googlesource.com/1008610
    > Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    > Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#550171}
    
    TBR=fsamuel@chromium.org,samans@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 672962
    Change-Id: Ib3730fc78117cbaac36d141bfe03430a665bb3ea
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1012785Reviewed-by: default avatarFady Samuel <fsamuel@chromium.org>
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551150}
    51fc7449
client_layer_tree_frame_sink.h 5.59 KB