• Nate Fischer's avatar
    AW: fix and enable flaky test · 52c77521
    Nate Fischer authored
    This enables
    testExitFullscreenEndsIfAppInvokesCallbackFromOnHideCustomView. This
    test flaked because DOMUtils was unreliable for clicking links. This CL
    swaps out DOMUtils for EvaluateJavaScriptWithUserGesture (since the
    relevant blink code requires user gesture and has no way to turn it off
    for testing).
    
    This plumbs EvaluateJavaScriptWithUserGesture to Java in a testonly
    target, so the Java method will not be present in production (and so
    this change should have no security implications).
    
    R=boliu@chromium.org
    
        --repeat=1000 \
        --gtest_filter=AwContentsClientFullScreenTest#testExitFullscreenEndsIfAppInvokesCallbackFromOnHideCustomView
    
    Bug: 789306
    Test: run_webview_instrumentation_test_apk --break-on-failure \
    Change-Id: I4407ce0daa399fbb289d4c9d74e3d9b64bccfcbf
    Reviewed-on: https://chromium-review.googlesource.com/c/1286031Reviewed-by: default avatarBo <boliu@chromium.org>
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#600579}
    52c77521
web_contents_utils.cc 2.5 KB