• Aldo Culquicondor's avatar
    Reland "VR: Adding move support for the platform UI" · 53195553
    Aldo Culquicondor authored
    This is a reland of d51d3420
    Previously, we were DCHECKing that touch handles were not being enabled
    during VR browsing. This caused some tests to crash, since the VR browser
    can not control when those calls are produced. Instead, this CL merges
    all the requirements for disabling the touch handles, including the VR mode.
    
    Original change's description:
    > VR: Adding move support for the platform UI
    >
    > This enables touch interaction with the web contents, effectively
    > enabling long press, drag, selection, etc.
    >
    > Context menu and selection handles are disabled for VR in this CL.
    >
    > Bug: 842916, 733656, 848740
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr
    > Change-Id: If50401ddbc130abde697b57d580bc492de2c4dda
    > Reviewed-on: https://chromium-review.googlesource.com/1091281
    > Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
    > Reviewed-by: Ted Choc <tedchoc@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567745}
    
    Bug: 842916, 733656, 848740
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I405c57fb91324758834f2d7afe21bb9c2bc937d4
    Reviewed-on: https://chromium-review.googlesource.com/1104638Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Reviewed-by: default avatarTimothy Dresser <tdresser@chromium.org>
    Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#568609}
    53195553
vr_shell_gl.cc 98.7 KB