• Collin Baker's avatar
    Don't capture thumbnails for visible pages · 53285a15
    Collin Baker authored
    A captured tab going into fullscreen is treated differently: instead
    of taking up the entire screen, it only fills the browser's contents
    container. This is to allow tabs to enter fullscreen while being
    streamed without disrupting the user. For example, fullscreening a
    video during capture will cause the video to fill the tab contents
    rather than the whole screen.
    
    Thumbnail capture uses this same infrastructure but shouldn't affect
    any user-visible behavior. This CL prevents thumbnails from being
    captured on visible tabs.
    
    Ideally we'd be able to put a capture hold on a WebContents without
    affecting fullscreen behavior, but implementing that is a larger
    investment. Fixing this bug is a high priority.
    
    Bug: 1112607
    Change-Id: I58cc53b2d881bf65cf2a9cb70d1a5d1592d02ad2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354728
    Commit-Queue: Collin Baker <collinbaker@chromium.org>
    Reviewed-by: default avatarDana Fried <dfried@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#800795}
    53285a15
thumbnail_capture_driver_unittest.cc 12 KB