• Patti's avatar
    Page Info Android: Fix PageInfoTest.NonFactoryDefault...Shown test bug. · 537399fd
    Patti authored
    ShouldShowPermission() in page_info.cc always returns true for geolocation on
    Android because Android does additional filtering to check if geolocation should
    be shown due to DSE settings.
    The test PageInfoTest.NonFactoryDefaultAndRecentlyChangedPermissionsShown
    touches upon this in testing, but was coincidentally passing on Android because
    it later expects geolocation to be shown regardless by changing it to a
    non-default setting. Fix by changing the vector of the expected permissions to a
    
    std: :set instead.
    Change-Id: I9841563ddb6add41ea6f4d2edea4569d16b879a9
    Reviewed-on: https://chromium-review.googlesource.com/813439Reviewed-by: default avatarRaymes Khoury <raymes@chromium.org>
    Commit-Queue: Patti <patricialor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#523691}
    537399fd
page_info_unittest.cc 41.6 KB