GitLab

Rename private methods for consistency: Start*() for something that invokes
an async operation and Handle*() for something that gets called back by such
an operation.  That leaves On*() reserved for observers.  Also update some
comments.  Lastly, use the current state key from the parameter passed to
HandleStateKeysResult() instead of requesting it again from the broker (line
222).

EnrollmentHandlerChromeOS and EnrollmentScreen: Don't report metrics on
unreached code paths.  Generally, remove some obsolete instances of
NOTREACHED() after switches over enums:  The compiler ensures that all enum
values are covered, there's no need to complicate the code by checking the
same thing again.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290841

Review URL: https://codereview.chromium.org/465413002

Cr-Commit-Position: refs/heads/master@{#293640}