GitLab

This reverts commit cb3af0b9.

Reason for revert: This cl introduced MSan bot failure.

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/2975

[ RUN      ] SSLClientSocketTest.SessionCacheShard
HTTPS server started on https://127.0.0.1:39100...
sending server_data: {"host": "127.0.0.1", "port": 39100} (36 bytes)
==19370:19370==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0xb1f3705 in net::SSLClientSocketImpl::DoHandshakeComplete(int) net/socket/ssl_client_socket_impl.cc:1175:39
    #1 0xb1eb33f in net::SSLClientSocketImpl::DoHandshakeLoop(int) net/socket/ssl_client_socket_impl.cc:1388:14
    #2 0xb1f44fe in net::SSLClientSocketImpl::OnHandshakeIOComplete(int) net/socket/ssl_client_socket_impl.cc:1365:12


[ RUN      ] SslCastSocketTest.TestMessageEndToEndWithRealSSL
==27991:27991==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x12dacae5 in net::SSLClientSocketImpl::DoHandshakeComplete(int) net/socket/ssl_client_socket_impl.cc:1175:39
    #1 0x12da471f in net::SSLClientSocketImpl::DoHandshakeLoop(int) net/socket/ssl_client_socket_impl.cc:1388:14
    #2 0x12dad8de in net::SSLClientSocketImpl::OnHandshakeIOComplete(int) net/socket/ssl_client_socket_impl.cc:1365:12




Original change's description:
> Disable session caching with the default (empty) shard.
> 
> Until we do https://crbug.com/458365 and remove the global session
> cache, consumers making SSLClientSockets with the default empty shard
> should not enable session caching, as they'll interact with other
> sockets which do that.
> 
> Bug: 458365
> Change-Id: Ib8bb5cc6fb51240c4e9a89184ab51775e9653168
> Reviewed-on: https://chromium-review.googlesource.com/595155
> Commit-Queue: Steven Valdez <svaldez@chromium.org>
> Reviewed-by: Steven Valdez <svaldez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491118}

TBR=davidben@chromium.org,svaldez@chromium.org

Change-Id: Id7dc73921a36d80c9764bbb49ae36c19ef2ccaca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 458365
Reviewed-on: https://chromium-review.googlesource.com/597328Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491232}