• Roger Tawa's avatar
    Fix for duplicate string resource error using link.exe. · 53d2ef8b
    Roger Tawa authored
    The new linker reports fatal errors during the build on windows when
    duplicate strings resources are defined.  Both installer_utils and gaiacp
    use generate_embedded_i18n.gni to generate their strings which causes them
    to use overlapping string resource IDs.  However, tests don't need to link
    with gaiacp strings, so this CL reduces the test dependencies on gaiacp.
    
    Add a dependency to installer/util:strings to tests that need it.
    
    browser_tests, interactive_ui_tests, and related tests that use
    ChromeTestLauncherDelegate need to have the installer's strings since
    they adjust Windows firewall rules.
    
    Bug: 958955
    Change-Id: I51659aab3b79bda81d1583e7e75feaa11269d3b8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602732Reviewed-by: default avatarNico Weber <thakis@chromium.org>
    Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Commit-Queue: Roger Tawa <rogerta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#659032}
    53d2ef8b
BUILD.gn 1.37 KB