• Joel Hockey's avatar
    Separate browser theme NTP and active tab colors · 546c62fc
    Joel Hockey authored
    The related bug shows that infobar is using the wrong color for
    non-tabbed PWAs. Infobar takes its color from the active tab color,
    and non-tabbed PWAs are currently setting active tab color to the
    theme color (rather than alt color) in order to get the desired NTP
    page during page load.
    
    The fix here is to roll back some of crrev.com/c/2094484 and set
    active tab color back to the alt color, and then to separate NTP
    and active tab colors so that NTP can be kept with the desired
    theme color.
    
    All other clients of BrowserThemePack are unchanged since ntp_color
    is taking active tab color in GetAutogeneratedThemeColors.  Only
    AppBrowserController is changing for non-tabbed PWAs to set alt color
    for active_tab (fixes bug relating to info bar), but can now keep
    the theme color for NTP so as not to regress crbug.com/1059696.
    
    For reference the previous changes for AppBrowserController:
    crrev.com/c/2045278
    crrev.com/c/2064164
    crrev.com/c/2094484
    
    Screenshots: crbug.com/1096027#c1
    
    Bug: 1096027
    Change-Id: I7db5a2836fef381116b4082b1fde219ba8bdec95
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248391Reviewed-by: default avatarAlan Cutter <alancutter@chromium.org>
    Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#779686}
    546c62fc
autogenerated_theme_util.cc 5.13 KB