• Marc Treib's avatar
    Add a first integration test involving both Sync and PasswordManager · 546fc2fa
    Marc Treib authored
    The test sets up Sync-the-transport, has the user opt-in to the account
    password storage, and makes sure that saves go to the correct store.
    
    This requires a few changes to password_manager_test_base.h/cc:
    - Most notably: The password manager tests used to set up a
      MockPasswordFeatureManager (in order to make IsGenerationEnabled()
      return true), but the new combined tests require a real
      PasswordFeatureManager. So this CL removes the mock (which also lets
      us remove CustomPasswordManagerClient), and instead sets up a
      TestSyncService which claims "everything is active" and so also makes
      IsGenerationEnabled() true.
    - Some simple refactorings to avoid duplicating test setup code:
      - Split the "GetNewTab" part out of SetUpOnMainThreadAndGetNewTab(),
        into a new static helper.
      - Exposed PasswordStoreResultsObserver (it used to be fully defined
        in the .cc).
      - Exposed a version of CheckThatCredentialsStored() that takes a
        PasswordStore parameter.
    
    Bug: 1058339
    Change-Id: If9b040cbd56ee10ba6b6badd1b4b4d772603f13a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089825
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Reviewed-by: default avatarMohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#749220}
    546fc2fa
BUILD.gn 352 KB