• Ahmed Fakhry's avatar
    Rotate display keyboard shortcut behavior in tablet physical state · 5541eb34
    Ahmed Fakhry authored
    When the device is physically used as a tablet (e.g. detached or
    flipped), the keyboard shortcut to rotate the display should
    behave as a request to lock the user orientation to the next
    rotation of the internal display.
    
    App windows are allowed to lock the rotation to a particular
    orientation in tablet UI mode on the internal display only.
    In this case, the shortcut should switch between the allowed
    rotations if any, or do nothing.
    
    For example:
    - If a window locks the rotation to kPortrait, the shortcut should
      switch the user rotation lock between kPortriatPrimary and
      kPortraitSecondary.
    - If a window locks the rotation to kPortraitSecondary, then the
      shortcut should do nothing.
    
    BUG=925087, 1026398
    TEST=Manually, Added a new test.
    
    Change-Id: I34bf76a336ef81de4f1f5269843a3dd8c5efcd4a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892054
    Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#721293}
    5541eb34
screen_orientation_controller.cc 26.9 KB