• Christopher Lam's avatar
    Replace is_installable in InstallableManager with valid_manifest and has_worker. · 55702f68
    Christopher Lam authored
    This CL splits the two components of the 'installable' check into its two
    components. This makes it clearer to clients what they are checking for
    and removes the confusion that a check that returns 'installable' may
    not actually be installable given the context of the check (e.g icons
    may be required for PWA installability).
    
    Further, the CL extracts the service worker wait behavior into a
    required argument in order to make explicit the checking and callback
    behavior. This prevents clients naively blocking forever on the callback
    on sites which have no service worker, which was previously the default
    behavior of InstallableParams.
    
    Bug: None
    Change-Id: I13b76d3d651e5ba9a9c1b7055bcc5f72689a2ea1
    Reviewed-on: https://chromium-review.googlesource.com/704475
    Commit-Queue: calamity <calamity@chromium.org>
    Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#508602}
    55702f68
app_banner_manager_android.cc 12.3 KB