• Xinghui Lu's avatar
    Move more classes under the feedback module. · 55d1d21b
    Xinghui Lu authored
    One major refactoring in this CL is removing FeedbackCollector's
    dependency on ScreenshotTask, because ScreenshotTask is not
    modularizable at the moment. Replace the takeScreenshot parameter in
    the init function with a ScreenshotSource object(the interface of
    ScreenshotTask), so FeedbackCollector doesn't need to construct a
    ScreenshotTask itself.
    
    Some outstanding blockers for further modularization:
    * DataReductionProxyFeedbackSource, blocked on
    DataReductionProxySettings.
    * HelpAndFeedbackLauncherImpl, blocked on AppHooks.
    * ScreenshotTask, blocked on ChromeActivity.
    * connectivity_checker.cc, blocked on circular dependency of
    chrome/browser/profiles.
    
    Bug: 1117343
    Change-Id: I93dd06b4146ad57d53c0cdc082d8ff0c9a32cdc0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478108Reviewed-by: default avatarJinsuk Kim <jinsukkim@chromium.org>
    Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
    Reviewed-by: default avatarNatalie Chouinard <chouinard@chromium.org>
    Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#821820}
    55d1d21b
system_info_feedback_source.cc 1.66 KB