• Kevin Bailey's avatar
    Revert "[omnibox] Select all when we revert all" · 5604cb88
    Kevin Bailey authored
    This reverts commit 3dc51db9.
    
    Reason for revert: For some reason, this change causes a 25% increase in GL rendering for Windows. See crbug.com/739303
    
    Original change's description:
    > [omnibox] Select all when we revert all
    > 
    > If you look at all the times we call RevertAll(), they either also call
    > SelectAll(true), or wouldn't mind if we did. To simplify both
    > RevertAll() and the calling code, we now make this call unconditionally.
    > It happens to fix an issue also, where a stale cursor is produced when
    > tabbing into the Omnibox.
    > 
    > Bug: 735802
    > Change-Id: Ib70f3ffd88555ef6aa600e17f111f22442e94eb0
    > Reviewed-on: https://chromium-review.googlesource.com/548985
    > Commit-Queue: Kevin Bailey <krb@chromium.org>
    > Reviewed-by: Trent Apted <tapted@chromium.org>
    > Reviewed-by: Peter Kasting <pkasting@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#483362}
    
    TBR=pkasting@chromium.org,tapted@chromium.org,krb@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 735802
    Change-Id: I4d075e5c5a20707f74bd2d330d466f67a3241ce8
    Reviewed-on: https://chromium-review.googlesource.com/563482Reviewed-by: default avatarKevin Bailey <krb@chromium.org>
    Commit-Queue: Kevin Bailey <krb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#484992}
    5604cb88
omnibox_edit_model.cc 59.7 KB