-
Jacob Dufault authored
Reason for revert: the failing test was flaky without this change and has since been disabled (crbug.com/911154) Original change's description: > Revert "cros: Remove WizardInProcessBrowserTest" > > This reverts commit 92925c66. > > Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 > > rowserTestBase received signal: Terminated. Backtrace: > #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() > #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() > #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7feafb349cb0 <unknown> > #4 0x7feafb4116d3 epoll_wait > #5 0x7feb2e96353f epoll_dispatch > #6 0x7feb2e956cc5 event_base_loop > #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() > #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() > #9 0x7feb2e6eb322 base::RunLoop::Run() > #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() > #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() > > Original change's description: > > cros: Remove WizardInProcessBrowserTest > > > > The base class convoluted the inheritance structure and it is simpler to > > directly derive from InProcessBrowserTest. > > > > Bug: 899777 > > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612394} > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org > > Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 899777 > Reviewed-on: https://chromium-review.googlesource.com/c/1356168 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612523} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 899777 Change-Id: Id6a54d588736969830db39963f5cc4560d1068b9 Reviewed-on: https://chromium-review.googlesource.com/c/1359135Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#613244}
56848201