• Rohit Rao's avatar
    [ios] Fixes a crash in Bookmarks. · 56a16746
    Rohit Rao authored
    If the bookmarks UI was displayed before the BookmarkModel was done
    loading, we would incorrectly cache a pointer to a BookmarkNode that had
    been destroyed.  Instead, do not set the root node of the
    BookmarkHomeViewController until after the model has finished loading.
    
    BUG=839883
    TEST=See repro steps in bug. Displaying the Bookmarks UI immediately upon startup should not crash.
    
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I062171c6d588da6be666b92e0c961abb90f1af17
    Reviewed-on: https://chromium-review.googlesource.com/1044353Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
    Commit-Queue: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#556101}
    56a16746
bookmark_interaction_controller.mm 14.3 KB