• Scott Violet's avatar
    cct-incognito change · 56d14ed0
    Scott Violet authored
    My intention is to merge this to 88.
    
    This adds the following changes to cct:
    1. context menu when in incognito mode no longer shows
       'open in chrome'. As the app menu explicitly doesn't show 'open in
       chrome' I'm assuming it's an over site that 'open in chrome' is
       shown in the context menu. If this isn't an over site, I can hide
       this behind the flag I previously added.
    2. Makes it possible for first parties to use this regardless of the
       feature state if an extra is present. Reason for this is I plan to
       merge this to 88, in which the feature is disabled.
    3. Makes it possible for colors to come from the intent. This is only
       enabled if an extra is present in the bundle and restricted to first
       parties.
    4. Makes it possible for not show the incognito icon. This is only
       enabled if an extra is present in the bundle and restricted to first
       parties.
    
    BUG=1157916
    TEST=Various tests in CustomTabActivityIncognitoTest
    
    Change-Id: I812f46e935dcae01b8d161893059ecf81c146522
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582643
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: default avatarRohit Agarwal <roagarwal@chromium.org>
    Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#837117}
    56d14ed0
chrome_java_sources.gni 128 KB