• Ankit Kumar 🌪️'s avatar
    Migrate pp::Rect to gfx::Rect in PDFiumEngine · 56d27510
    Ankit Kumar 🌪️ authored
    Update PDFiumEngine to use gfx::Rect instead of pp::Rect. Update
    callers to expect gfx::Rect as return value instead of pp::Rect.
    
    Noteworthy points:
    - In pp::Rect, Subtract() is a utility methods which takes in two
    rects and returns the subtracted rect. Whereas in gfx::Rect, Subtract()
    is a member method which modifies the rect in-place. All usage of
    Subtract() which are replaced in the CL modify the rect in-place.
    - In pp::Rect, Intersect() is a utility method which takes in two
    rects and returns the intersected rect. The counterpart in gfx::Rect
    is IntersectRects() and not Intersect().
    
    Bug: 1101101
    Change-Id: Ib071e3a987c2c234b8e2348744700f9cf07edc96
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379397Reviewed-by: default avatarK. Moon <kmoon@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#804462}
    56d27510
out_of_process_instance.h 19.3 KB