• Emily Stark's avatar
    Revert "Restore omnibox bounds when resetting if not eligible for eliding" · 56db3421
    Emily Stark authored
    This reverts commit 8ea67049.
    
    Reason for revert: I noticed that this change causes the omnibox to be in ELIDE_TAIL mode during editing, which causes a DCHECK failure.
    
    Original change's description:
    > Restore omnibox bounds when resetting if not eligible for eliding
    > 
    > This CL fixes a bug in the code that resets to the on-page-load state
    > for the simplified domain hide-on-interaction field trial.
    > 
    > The bug is that this reset code let the omnibox bounds go unchanged
    > if the new text was not eligible for simplified domain eliding.
    > For example, when switching to a new tab (as shown in
    > https://bugs.chromium.org/p/chromium/issues/detail?id=1112577#c4), the
    > placeholder text could get cut off because the omnibox was remaining
    > at the bounds used for the last simplified domain elision. The fix is
    > to restore the omnibox to its local bounds, with ELIDE_TAIL behavior,
    > when the text is not eligible for simplified domain eliding.
    > 
    > Bug: 1107912, 1112577
    > Change-Id: I36c359831fc1f7b18c814d9144b801655bd3b1c5
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342123
    > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
    > Commit-Queue: Emily Stark <estark@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#795953}
    
    TBR=jdonnelly@chromium.org,estark@chromium.org
    
    Change-Id: Id44cd8e39064af890399109fcca8ca729ddba5d4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1107912
    Bug: 1112577
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343153Reviewed-by: default avatarEmily Stark <estark@chromium.org>
    Commit-Queue: Emily Stark <estark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#796133}
    56db3421
omnibox_view_views.h 28.8 KB