• Malay Keshav's avatar
    Fix immediate pref value change in display resolution settings · 5730340b
    Malay Keshav authored
    We use a change observer to trigger updating the selected mode of a
    display. This is useful for the drop down menu we use to select the mode
    on external displays. However, if display zoom is disabled, we show a
    slider instead of a drop down. The slider triggers the same pref value
    change even if the user is still dragging it. This causes a usability
    regression on the settings resolution slider.
    
    To fix this, the patch adds a check which ensures we only listen to
    events fired due to releasing the slider when display zoom is disabled.
    
    Bug: 845712
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I9965bdf3121289ac29f38175cc9ad179cda41497
    Component: Display settings, resolution slider
    Reviewed-on: https://chromium-review.googlesource.com/1069773
    Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
    Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#562555}
    5730340b
display.js 26.3 KB