- 29 May, 2018 40 commits
-
-
Malay Keshav authored
We use a change observer to trigger updating the selected mode of a display. This is useful for the drop down menu we use to select the mode on external displays. However, if display zoom is disabled, we show a slider instead of a drop down. The slider triggers the same pref value change even if the user is still dragging it. This causes a usability regression on the settings resolution slider. To fix this, the patch adds a check which ensures we only listen to events fired due to releasing the slider when display zoom is disabled. Bug: 845712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9965bdf3121289ac29f38175cc9ad179cda41497 Component: Display settings, resolution slider Reviewed-on: https://chromium-review.googlesource.com/1069773 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#562555}
-
Marcin Wiacek authored
Change-Id: I16161b7a07ed8291bb252f81cd568c3cf847c402 Reviewed-on: https://chromium-review.googlesource.com/1075311Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#562554}
-
Max Rebuschatis authored
This change adds the capability to request a hit-test on an XRSession. The session queries the magic window provider to get any hits based on the given ray and then resolves a promise with an array of hit results. This test is added by https://crrev.com/c/1040880, which will land immediately after this one. Bug: 833633 Test: third_party/WebKit/LayoutTests/xr/ar_hittest.html Change-Id: I225297bcf052765f156790a588eafb817ed75e08 Reviewed-on: https://chromium-review.googlesource.com/1018524 Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#562553}
-
Nico Weber authored
Bug: 843511,845598 Change-Id: I17b82fb59da08c5522148d5bf57d8c8bbad9b6d6 Reviewed-on: https://chromium-review.googlesource.com/1069228 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#562552}
-
erikchen authored
There was a race condition that could cause the vm region map in a memlog trace to contain full file paths. This happened if the CoordinatorImpl callback occurred before the TracingController was able to set the TracingConfig on TraceLog. Change-Id: If3b424ed13b91a0bd644316fe1a7b30a6254b191 Reviewed-on: https://chromium-review.googlesource.com/1072312Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562551}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/66c64a74..8030067c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia8c9e477d466ca695a9b656f5e41e2ba945f0bcc Reviewed-on: https://chromium-review.googlesource.com/1076503Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#562550}
-
Scott Haseley authored
FrameScheduler already handles timer freezing, and there isn't anything (non-trivial) left on default timer queue, so this should be safe. Per-frame timer queue is controlled by FrameScheduler. This patch also moves |frozen_when_backgrounded| into the Policy. Bug: 820634 Change-Id: I95527a9919d37647a13e59ebcceede5fa36774c6 Reviewed-on: https://chromium-review.googlesource.com/1073649 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#562549}
-
Robert Sesek authored
Bug: 847518 Change-Id: Icd279d0a71e9c7b617c965674ee76d37ef23b29f Reviewed-on: https://chromium-review.googlesource.com/1076354Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#562548}
-
David Michael Barr authored
linux/arm for targets without NEON support. linux/arm-neon-cpu-detect for deprecated(Bug 448055) Android config. Bug: 783519 Change-Id: Ib050ed227ddfcd759efbe08e80a781ca6f675dbe Reviewed-on: https://chromium-review.googlesource.com/1068902 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#562547}
-
Ken Rockot authored
ExtensionWebRequestApiTest.WebRequestAuthRequired has been disabled forever. It was originally disabled for flakiness, but neither the flaky crashes nor the code which was crashing appear to exist anymore. This CL makes some minor updates to the test expectations and re-enables the test. Bug: 140976,841827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I97879b51e600cff684defcbef37fcfbae3dfda62 Reviewed-on: https://chromium-review.googlesource.com/1076683Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#562546}
-
Ahmed Fakhry authored
In order to be able to set the Color Transform Matrix (CTM) and a default gamma/degamma Loopup Tables (LUTs) separately for Night Light on the Cathode Ray Tube Controller (CRTC), this CL splits the existing API into two separate calls. BUG=749250 TEST=Updated tests in DisplayColorManagerTest and NightLightCrtcTest. Change-Id: Ic21475e7a5d86dd8d2df9f6e3ef8eb16ee213d84 Reviewed-on: https://chromium-review.googlesource.com/1070317Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#562545}
-
Yuke Liao authored
This CL adds a builder to chromium.fyi to generate code coverage reports on linux platform. Bug: 825362 Change-Id: If3942d9a7b37da6db2d40bc0b04ad7ac89460deb Reviewed-on: https://chromium-review.googlesource.com/1073071Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#562544}
-
Brian Anderson authored
* Enable FrameMetrics to differentiate between source type, source thread, and compile target. * Report sample count for worst windows. * Move tracing logic from StreamAnalyzer to StreamAnalysis, which allows results to be stored and traced at a later point. Bug: 790759 Change-Id: I763a0f354d97119c16635675a2b9fa29a947f417 Reviewed-on: https://chromium-review.googlesource.com/1072872 Commit-Queue: Brian Anderson <brianderson@chromium.org> Reviewed-by:Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#562543}
-
Findit authored
This reverts commit 2c24de69. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 562467 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJjMjRkZTY5NTMyY2IyNmNjMTk5YmIwN2Y5ZWJmYTY3MzBiYzI2ZTIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/69346 Sample Failed Step: chrome_elf_unittests Original change's description: > [chrome_elf, third-party block support] full hook testing. > > Adding some full tests, including some corner cases. These tests > initialize the whole third_party_dlls project, to exercise the new hook. > > Non-test adjustments: > - pe_image_safe: |directory| == 0 is valid! (export dir) > - hook: Exposed a GetDataFromImageForTesting() function. > Also a few fixes in the hook shim: > * Use the PEImageSafe constructor that takes an HMODULE. > * Use the new GetFingerprintString() api. > * Don't hash an empty image or section name. > * Pass a name hash instead of non-hashed into LogLoadAttempt > if a DLL was allowed. > - packed_list_file: > * GetFingerprintHash() removed from this project. > * Also, gracefully handle a blacklist file that exists, but is empty. > - packed_list_format: > * Added "new" GetFingerprintString() API here. > It centralizes the format string without doing the hash. > > Test: chrome_elf_unittests.exe, ThirdPartyTest.* > Bug: 769590 > Change-Id: I592f76b884312bb267eb6747a478e271fc96e689 > Reviewed-on: https://chromium-review.googlesource.com/1069694 > Commit-Queue: Penny MacNeil <pennymac@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562467} Change-Id: I46cf1feddbc80a60ca92b44152d2f7ad0ef865e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769590 Reviewed-on: https://chromium-review.googlesource.com/1077029 Cr-Commit-Position: refs/heads/master@{#562542}
-
Miguel Casas authored
Removed handling of gfx::BufferFormat::BGRX_1010102 from gl_image_native_pixmap, because we support XB30 instead. Bug: 776093 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I07a54ca42af9469df10469776ff3e3f4d3b0b09c Reviewed-on: https://chromium-review.googlesource.com/1073052Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#562541}
-
Georges Khalil authored
This change adds the necessary reported fields from within Chrome to remove the need for the native host. BUG=847264 Change-Id: Id7e0489749c7e878c023d698e9f56ea0b2ef4ab9 Reviewed-on: https://chromium-review.googlesource.com/1074498 Commit-Queue: Georges Khalil <georgesak@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#562540}
-
Sebastien Marchand authored
This forwards the |kNonPersistentNotificationCreated| events received in services/resource_coordinator/ to the page signal observer on the browser side (c/b/rc). Non-persistent notifications are web notifications created by a page, they require the page to be alive to be created (persistent notifications are created by service workers and don't rely on the page to be alive) These events will be recorded in the local site characteristics database in a further CL. We need to consider potential usage of non-persistent web notifications before proactively discarding a tab to make sure that we don't discard a tab that could try to communicate with the user via non-persistent web notifications. Bug: 773382 Change-Id: I0245cd4514541a2f70b547d5ce9fab0e633ddf94 Reviewed-on: https://chromium-review.googlesource.com/1068665Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#562539}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 58bfcc57. With Chromium commits locally applied on WPT: d78c1e54 "[Resource-Timing] Fix `initiatorType` values" 6534acd9 "[css-grid] Baseline alignment inside the tracks sizing algorithm" acf0cdd6 "Clamp argument to SVGGeometryElement.getPointAtLength to [0, length]" 63ca6994 "CSS: ::part invalidation layout tests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18903 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ifccae2f41c6b5c9f5c88f64f78e8134bc6d9bdbd Reviewed-on: https://chromium-review.googlesource.com/1076322 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#562538}
-
Xiaohan Wang authored
- In CdmAdapter, do not expose a Decryptor is CdmProxy is requested. - In MojoCdm, support CDM ID based Decryptor in MojoCdm. - Implement ClearKeyCdmProxy::SetKey() to load a license in its AesDecryptor so it can perform decryption. - Update ECKEncryptedMediaTest.CdmProxy test to cover playback using ClearKeyCdmProxy to do decryption. TBR: rkuroiwa@chromium.org Bug: 806018 Test: ECKEncryptedMediaTest.CdmProxy covers the new path Change-Id: Icd1cbddb8535f9b2ef5b20c3b1535d8c41dbb19c Reviewed-on: https://chromium-review.googlesource.com/1071073 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#562537}
-
Will Harris authored
BUG=846436 Change-Id: I9b3b504c75660d9d65fe24bbf0c592915f9f6b19 Reviewed-on: https://chromium-review.googlesource.com/1072508 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#562536}
-
John Chen authored
This reverts commit 47c575ab. Reason for revert: Causes noticeable slowdown on Windows and some Mac. Reverting for now, and will re-visit after ChromeDriver 2.39 release. Original change's description: > Reland "[ChromeDriver] Use Browser.close to quit" > > This is a reland of 3edba584 > > Original change's description: > > [ChromeDriver] Use Browser.close to quit > > > > Currently, ChromeDriver closes desktop Chrome by simply killing the > > top-level Chrome process. This isn't graceful, and causes problems > > in some scenarios. This commit sends a Browser.close command to close > > the browser gracefully. > > > > Bug: chromedriver:2311 > > Change-Id: Idec9338b094f0aab89022b8453dd2a98268ad1e7 > > Reviewed-on: https://chromium-review.googlesource.com/1037585 > > Commit-Queue: John Chen <johnchen@chromium.org> > > Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#556689} > > TBR=kereliuk@chromium.org > > Bug: chromedriver:2311 > Change-Id: I302e064532fdadb1b6e40d53fbfe3cf72601a731 > Reviewed-on: https://chromium-review.googlesource.com/1054117 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557613} TBR=johnchen@chromium.org,kereliuk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromedriver:2311 Change-Id: Iabef56858621949e02e431e9df4a03649572f5da Reviewed-on: https://chromium-review.googlesource.com/1077027Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562535}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0043a4a..edb9947 git log 0043a4a..edb9947 --date=short --no-merges --format='%ad %ae %s' 2018-05-25 dtu@chromium.org [dashboard] Bug ID is not optional. Created with: gclient setdep -r src/third_party/catapult@edb9947 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I564a374aa6448149c29cbac0673e25aa5e30a39f Reviewed-on: https://chromium-review.googlesource.com/1076776 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562534}
-
Geoff Lang authored
This ensures that the passthrough command decoder is tested on developer builds. BUG=738568 BUG=602688 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3cb473c51d8c889f958827233ca67d6cf6b7fb04 Reviewed-on: https://chromium-review.googlesource.com/1075507Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#562533}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1d1edc1..bfb2a05 git log 1d1edc1..bfb2a05 --date=short --no-merges --format='%ad %ae %s' 2018-05-29 senorblanco@chromium.org GrTessellator: fix for ping-pong split fuzzer hang. 2018-05-29 bsalomon@google.com Revert "Make GrTextureOp disable coverage AA when rect falls on integers." 2018-05-25 mtklein@chromium.org wouldn't it be nice? 2018-05-29 brianosman@google.com Added drawAtlas support to SkDebugCanvas 2018-05-29 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 bcf467f..1e91374 (1 commits) 2018-05-29 fmalita@chromium.org Clean up modules/skottie/BUILD.gn 2018-05-29 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9d93107..4b74373 (3 commits) 2018-05-25 bsalomon@google.com Make GrTextureOp disable coverage AA when rect falls on integers. 2018-05-29 kjlubick@google.com Fix fuzz+Skottie integration Created with: gclient setdep -r src/third_party/skia@bfb2a05 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:838978 TBR=rmistry@chromium.org Change-Id: I44038547b25fa9aa0d3bbe7e0eaea219260a9149 Reviewed-on: https://chromium-review.googlesource.com/1076686Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562532}
-
Stuart Langley authored
Continue modernization of the drive code, using clang-tidy. This change replaces empty constructors/destructors with = default. Steps: $ autoninja -C out/Default chrome $ tools/clang/scripts/generate_compdb.py -p \ out/Default > compile_commands.json $ cd out/Default/ $ /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \ -clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \ -checks=-*,modernize-use-equals-default \ -header-filter= \ -fix components/drive No logic changes. No new tests. Bug: 841659 Change-Id: If1a85084575b632d3d29bd0dea021acbd8168b81 Reviewed-on: https://chromium-review.googlesource.com/1076570Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#562531}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7a0bb00..9a89a49 git log 7a0bb00..9a89a49 --date=short --no-merges --format='%ad %ae %s' 2018-05-29 mbonadei@webrtc.org Reland "Reland "Adding absl includes and defines to rtc_* templates."" 2018-05-29 henrika@webrtc.org Thread checker fails when switching to/from bluetooth headset. 2018-05-29 buildbot@webrtc.org Roll chromium_revision 04484f1a..eb7233ce (562301:562409) Created with: gclient setdep -r src/third_party/webrtc@9a89a49 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:845158,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibc93ff67e5dd4c965ccb5d1f605963b4a1017057 Reviewed-on: https://chromium-review.googlesource.com/1076678 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562530}
-
Veranika Liaukevich authored
This will allow other projects that depend on parts of Chromium, but not on //net, declare traffic annotations without pulling in the whole //net, but only tiny //net/traffic_annotation. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7e73259f01a668dba84d40da195077cd6636e2d5 Reviewed-on: https://chromium-review.googlesource.com/1073870Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Veranika Liaukevich <veranika@chromium.org> Cr-Commit-Position: refs/heads/master@{#562529}
-
Patrick Hulce authored
BUG=845406,847350,846607 Change-Id: Id3ed220dcaf00cfbed5ba7b02e27412eab09b219 Reviewed-on: https://chromium-review.googlesource.com/1076325Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#562528}
-
Becca Hughes authored
The Blink runtime enabled feature name should line up with the Chrome one. BUG=838400 Change-Id: Ic74d6abf99edf1c1ff8a5b18eedcca34edff9d3b Reviewed-on: https://chromium-review.googlesource.com/1073991Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#562527}
-
dpapad authored
The feature flag is no longer necessary, since the old UI has been deleted already, and the new UI is always served regardless of the feature's value. Bug: 846897 Change-Id: I782fa5e931d8da959119b73a77538a87ff425c80 Reviewed-on: https://chromium-review.googlesource.com/1073951 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#562526}
-
Jan Krcal authored
This CL improves the bug fix for an issue with TYPED_URL. Before this CL, one could hit DCHECK if typing an url that got expired in the current running instance of Chrome. The DCHECK was due to the sync entity still being tracked by ClientTagBasedModelTypeProcessor. Bug: 827111 Change-Id: If040ed1657a5ec3b1bdada79c994f14ec63ce893 Reviewed-on: https://chromium-review.googlesource.com/1076088 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#562525}
-
Dmitry Gozman authored
Bug: none Change-Id: I1342bd4f416a8e1f21d521efd6c05d535a3442c8 Reviewed-on: https://chromium-review.googlesource.com/1076684Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#562524}
-
Adithya Srinivasan authored
https://crrev.com/c/1070955 didn't update the test name. Bug: 846172 Change-Id: I40eef4081f090de148c64a635c13f352b230efda Tbr: rdevlin.cronin@chromium.org, fhorschig@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1076900Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#562523}
-
Khushal authored
R=enne@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iac62262f6c09fcfd9877b9fafca0bf7a3cb30545 Reviewed-on: https://chromium-review.googlesource.com/1076771Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#562522}
-
Erik Luo authored
- Adds 'pointer-events: none' so that hovering a tooltip does not cause a popover to blur and disappear. - Accounts for cursor offset when positioning a tooltip above the cursor. - Trims function tooltips everywhere to 500 chars. Screenshots: https://imgur.com/a/8mfMGXA https://imgur.com/a/aWsRsKX Bug: 806194 Change-Id: I64a479aa5d93b10ade286d59957c52df4997851c Reviewed-on: https://chromium-review.googlesource.com/1072738 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#562521}
-
Brian Salomon authored
Change-Id: I718bf290fc5ed488a14f96ae67e2d990a8ee5e74 Reviewed-on: https://chromium-review.googlesource.com/1076355Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#562520}
-
Jose Dapena Paz authored
There are several calls following this pattern: std:map<A, std::unique_ptr<B>> map; A a; std::unique_ptr<B> b; map.insert({a, std::move(b)}); This fails in gcc < 7.3 because the operator for inserting from && is not present, as reported here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82522 So apply a workaround that makes the move steps explicit. Change-Id: I54cea26eac6e74a3d9c2d17a37e3c4c9ce62fd74 Reviewed-on: https://chromium-review.googlesource.com/1076471Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#562519}
-
Xing Liu authored
BlackTitle3 and BlackSummary use color list that when the view is disabled, Android may render another color in the color list. This CL makes BlackTitle1/BlackBody to use the color list, and removes BlackTitle3/BlackSummary. Change-Id: I82f54578f2aacea4ec7c58af65fb79742b6ece2e Reviewed-on: https://chromium-review.googlesource.com/1069908Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#562518}
-
Dominic Mazzoni authored
Previously it was only updating when the mouse moved and the button was not held down, now it follows the mouse while dragging too. Tested manually by enabling the cursor highlight feature and watching the highlight while clicking and dragging to selecte text. Bug: 835683 Change-Id: I7ef693cf0f04519850d4cf5d617faca7c15f5763 Reviewed-on: https://chromium-review.googlesource.com/1074171Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#562517}
-
Robert Flack authored
Bug: 842495 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I41b3a973a2f9aa36e245e4cfbe1ad8f0de4b5ad8 Reviewed-on: https://chromium-review.googlesource.com/1075826 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#562516}
-