• Sebastien Marchand's avatar
    Hook up the delay load failure function in the renderer processes (Take 3) · 576d1fd0
    Sebastien Marchand authored
    This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1665913
    
    A whitelist has been added to allow "bthprops.cpl" to fail to be delay
    loaded as the failure will be intercepted by bluetooth_init_win.cc
    
    -------- Original CL description -------------
    
    This allows getting a crash report when failing to delay load a DLL.
    
    Example of the stack trace that this will provide:
    chrome_child!base::debug::BreakDebugger+0xc [C:\src\chrome\src\base\debug\debugger_win.cc @ 28]
    chrome_child!logging::LogMessage::~LogMessage+0x3f5 [C:\src\chrome\src\base\logging.cc @ 939]
    chrome_child!DllLoadHook+0x75 [C:\src\chrome\src\chrome\child\delay_load_failure_hook.cc @ 24]
    chrome_child!__delayLoadHelper2+0x13f [d:\agent\_work\3\s\src\vctools\delayimp\delayhlp.cpp @ 305]
    chrome_child!RtlUnwind+0x470
    chrome_child!SkFontMgr::legacyMakeTypeface+0x13 [C:\src\chrome\src\third_party\skia\src\core\SkFontMgr.cpp @ 164]
    chrome_child!blink::DWriteVersionSupportsVariations+0x7f
    chrome_child!blink::WebFontTypefaceFactory::FontManagerForVariations+0xc
    
    Bug: 970893, 976241
    Change-Id: I5a4981d81bcec92c4916481b5238a161bdb290f6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676996Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Reviewed-by: default avatarWill Harris <wfh@chromium.org>
    Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#672641}
    576d1fd0
delay_load_failure_hook.cc 1.69 KB