• James Cook's avatar
    Revert "ozone/drm: Use minigbm mmap for modeset buffers" · 57af9203
    James Cook authored
    This reverts commit b7eae9f9.
    
    Reason for revert: May be causing crashes in desktopui_MashLogin autotest in the Chrome OS lab. See crbug.com/882073
    
     0  libminigbm.so.1.0.0!gbm_bo_destroy [gbm.c : 153 + 0x0]
     1  chrome!gbm_wrapper::Buffer::~Buffer() [gbm_wrapper.cc : 121 + 0x5]
     2  chrome!ui::GbmPixmap::~GbmPixmap() [memory : 2321 + 0x5]
     3  chrome!gl::GLImageNativePixmap::~GLImageNativePixmap()  4  chrome!std::__1::__vector_base<gpu::gles2::Texture::LevelInfo, std::__1::allocator<gpu::gles2::Texture::LevelInfo> >::~__vector_base() [ref_counted.h : 352 + 0x3]
     5  chrome!gpu::gles2::Texture::~Texture() [texture_manager.cc : 652 + 0x9]
     6  chrome!gpu::gles2::Texture::RemoveTextureRef(gpu::gles2::TextureRef*, bool) [texture_manager.cc : 602 + 0x8]
    
    Original change's description:
    > ozone/drm: Use minigbm mmap for modeset buffers
    > 
    > FillModesetBuffer assumed all the buffers could be mmaped as dumb
    > buffers.
    > This doesn't work on some platforms.
    > 
    > This CL mmaps the modeset buffer using gbm_map instead, that should
    > work with tiled formats too.
    > 
    > Bug: b/78892556
    > Change-Id: I20ff9e54ea12e9866360021d8d9c5f7940f5b551
    > Reviewed-on: https://chromium-review.googlesource.com/1198451
    > Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
    > Reviewed-by: Michael Spang <spang@chromium.org>
    > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#589556}
    
    TBR=spang@chromium.org,dnicoara@chromium.org,dcastagna@chromium.org,ddavenport@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: b/78892556
    Change-Id: I7ceefac024f76d8f7b945ead19a36fb4a6a2e34a
    Reviewed-on: https://chromium-review.googlesource.com/1217022Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#589959}
    57af9203
gbm_buffer.h 1.37 KB