-
Findit authored
This reverts commit 2c24de69. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 562467 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJjMjRkZTY5NTMyY2IyNmNjMTk5YmIwN2Y5ZWJmYTY3MzBiYzI2ZTIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/69346 Sample Failed Step: chrome_elf_unittests Original change's description: > [chrome_elf, third-party block support] full hook testing. > > Adding some full tests, including some corner cases. These tests > initialize the whole third_party_dlls project, to exercise the new hook. > > Non-test adjustments: > - pe_image_safe: |directory| == 0 is valid! (export dir) > - hook: Exposed a GetDataFromImageForTesting() function. > Also a few fixes in the hook shim: > * Use the PEImageSafe constructor that takes an HMODULE. > * Use the new GetFingerprintString() api. > * Don't hash an empty image or section name. > * Pass a name hash instead of non-hashed into LogLoadAttempt > if a DLL was allowed. > - packed_list_file: > * GetFingerprintHash() removed from this project. > * Also, gracefully handle a blacklist file that exists, but is empty. > - packed_list_format: > * Added "new" GetFingerprintString() API here. > It centralizes the format string without doing the hash. > > Test: chrome_elf_unittests.exe, ThirdPartyTest.* > Bug: 769590 > Change-Id: I592f76b884312bb267eb6747a478e271fc96e689 > Reviewed-on: https://chromium-review.googlesource.com/1069694 > Commit-Queue: Penny MacNeil <pennymac@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562467} Change-Id: I46cf1feddbc80a60ca92b44152d2f7ad0ef865e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769590 Reviewed-on: https://chromium-review.googlesource.com/1077029 Cr-Commit-Position: refs/heads/master@{#562542}
57b6b5db