• Kevin McNee's avatar
    Revert "Change proxy disclosure at chrome://management" · 57d4ff14
    Kevin McNee authored
    This reverts commit 6d3e7bf2.
    
    Reason for revert: Tests fail under msan.
    https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20286
    e.g.
    [ RUN      ] ManagementUIHandlerTests.ProxyServerDisclosureDeviceOffline
    [14456:14456:0819/094542.091708:576654156:WARNING:server_backed_state_keys_broker.cc(72)] Failed to obtain server-backed state keys.
    ==14456==WARNING: MemorySanitizer: use-of-uninitialized-value
        #0 0x5640b0ca7d20 in ManagementUIHandlerTests::SetUpProfileAndHandler() ./../../chrome/browser/ui/webui/management_ui_handler_unittest.cc:437:9
        #1 0x5640b0cb6cc1 in ManagementUIHandlerTests_ProxyServerDisclosureDeviceOffline_Test::TestBody() ./../../chrome/browser/ui/webui/management_ui_handler_unittest.cc:972:3
    ...
    
    Original change's description:
    > Change proxy disclosure at chrome://management
    > 
    > Change the wording and location of the proxy server disclosure in the
    > transparency panel.
    > 
    > Bug: 1116961
    > Test: unittests
    > Change-Id: Id394511a6357329e629a37f19a4f83a4d49ea0db
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360073
    > Reviewed-by: Andreea-Elena Costinas <acostinas@google.com>
    > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
    > Reviewed-by: Greg Levin <glevin@chromium.org>
    > Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
    > Cr-Commit-Position: refs/heads/master@{#799604}
    
    TBR=antrim@chromium.org,glevin@chromium.org,mgalonsky@chromium.org,acostinas@google.com
    
    Change-Id: I9c1489950f8c2bf71d5ae78ca97f63fce806174e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1116961
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364481Reviewed-by: default avatarKevin McNee <mcnee@chromium.org>
    Commit-Queue: Kevin McNee <mcnee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#799769}
    57d4ff14
management_ui_handler.h 8.52 KB