• David Bokan's avatar
    Ignore XI2 window crossing for slave pointers · 581f2c72
    David Bokan authored
    This fixes the attached bug since the cause is that the XTest pointer
    is generating window crossing events (XI_Leave/XI_Enter) when implicitly
    capturing the pointer for the slave device. For physical devices, these
    events are generated only for the master pointer.
    
    This CL fixes it by letting the crossing events pass through the
    filtering checks applied by ShouldProcessXI2Event.
    pointer_device_lookup_ stores only the master pointers so this filters
    out the test slave.
    
    I haven't been able to determine what makes the XTest pointer but the
    fix makes sense since window crossing events only make sense on a
    pointer and in that case we should always use the master.
    
    Bug: 683434
    Change-Id: Id96dacb6db49a95fae33105de2fcfe2b9f8d1b44
    Reviewed-on: https://chromium-review.googlesource.com/883601
    Commit-Queue: David Bokan <bokan@chromium.org>
    Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#531882}
    581f2c72
touch_factory_x11.cc 12.7 KB