• Alexey Baskakov's avatar
    dpwa: Add unit test for backward compatibility. · 584cca70
    Alexey Baskakov authored
    BackwardCompatibility_WebAppWithOnlyRequiredFields tests the reading of the
    minimal proto data with `required` fields only.
    
    Any new fields in web_app.proto should be `optional` since the BMO
    project launch:
    we need backward compatibility for any previous user's data state.
    
    If `required` field gets added into web_app.proto, this test fails.
    
    It is still possible to add required fields to optional/repeated
    protos, like WebAppShortcutsMenuItemInProto, and this test will pass,
    so it's won't catch 100% of new required fields (only minimal).
    
    Bug: 1104718
    Change-Id: I1a76f19df6f9f5f81c838fc029467f1cd48c10a2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302977
    Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
    Reviewed-by: default avatarChris Mumford <cmumford@google.com>
    Cr-Commit-Position: refs/heads/master@{#791092}
    584cca70
web_app_database_unittest.cc 22.6 KB