• Demetrios Papadopoulos's avatar
    Revert "Don't propagate keydown events when dialog is open" · 5865a897
    Demetrios Papadopoulos authored
    This reverts commit ab21d472.
    
    Reason for revert: Broke
     - Print preview 'esc' behavior when dialog is open
     - Settings add-language-dialog ctrl+f behavior
    
    Original change's description:
    > Don't propagate keydown events when dialog is open
    > 
    > We shouldn't propagate keydown events so that it can
    > behave modally.
    > 
    > Bug: 883221
    > Cq-Include-Trybots: luci.chromium.try:closure_compilation
    > Change-Id: I4aa5257b4bf6c417123d659ba911cb01641a4cc7
    > Reviewed-on: https://chromium-review.googlesource.com/1230493
    > Reviewed-by: Scott Chen <scottchen@chromium.org>
    > Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#593619}
    
    TBR=calamity@chromium.org,scottchen@chromium.org,sangwoo108@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 883221
    Change-Id: I8f044d3e62ffce565a0761327b6aa877d1463224
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Reviewed-on: https://chromium-review.googlesource.com/1249809Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#594871}
    5865a897
AUTHORS 37.5 KB