• Toni Barzic's avatar
    Reland "Observe file modifications in FileChangeService" · 589df997
    Toni Barzic authored
    This is a reland of c52857a9
    
    The original cl missed calls to run_loop.Run() in test methods
    that wrote to a file, and waited for the write to finish.
    
    TBR=dats@chromium.org
    
    Original change's description:
    > Observe file modifications in FileChangeService
    >
    > Adds OnFileModified observer interface to FileChangeServiceObserver
    > called when the file is written, truncated, or copied to.
    >
    > Fixes file change service unit tests to verify that mocked observer
    > methods actually get called. The observers were previously not
    > getting invoked because the test suite did not set up fake chrome
    > user manager, so user account IDs were not correctly mapped to the
    > associated test profile, which is something
    > ObservableFileSystemOperationImpl depends on to get the
    > FileChangeService to notify of file changes.
    >
    > BUG=1139115
    >
    > Change-Id: I9829db0a496eec301a7f7547ac74f61bc1a18bdf
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603467
    > Reviewed-by: Sergei Datsenko <dats@chromium.org>
    > Reviewed-by: David Black <dmblack@google.com>
    > Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#839697}
    
    Bug: 1139115
    Change-Id: I70e23cd1b11c9168ee99d8ed314942d25bd4a004
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607415
    Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    Reviewed-by: default avatarDavid Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#839780}
    589df997
file_change_service.h 1.79 KB