GitLab

A whole slew of unrelated small changes:

* Use =default more
* Shorten code
* Better use of idioms like GetMainAxis(), ClampToRange(), StrCat(), etc.
* Attempt to improve comments (clearer, briefer, etc.)
* Change some {} constructions to constructor syntax.  Improves compliance
  with
  https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#variable-initialization
  and makes the type in question clearer.
* More use of pass-by-value-and-move where callee always copies.
* Reorder declarations to match definitions
* Eliminate default arg to AllocateFlexSpace(), which just decreased
  clarity slightly
* Remove unnecessary conditionals
* Eliminate else after return
* Declare variables as close to first use as possible
* Implement some equality checks with std::tie() (not required style,
  but mentioned in totw/43 and tends to reduce maintenance hassle when
  more fields are added; is also more consistent with how we already used
  it for some inequalities of these types)
* Fix badly-copy-and-pasted param names
* Remove unreachable code that also defeats warn-if-unhandled-enum-added

Bug: none
Change-Id: Ia0b22e1bc8981a3efc601d48c43180de4fd43f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021293
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736170}