• Evan Stade's avatar
    Reland "Make BrowserWithTestWindowTests work with single process Mash" · 59510e33
    Evan Stade authored
    This relands commit 01dd4ead.
    
    Breakage was due to in-flight conflict with 39536eb8
    Fix is just to update a few more function names that were added in
    that change.
    
    Original change's description:
    > Make BrowserWithTestWindowTests work with single process Mash
    >
    > The InputDeviceClient needs to only be created once, so remove it
    > from AuraTestSuiteSetup. Otherwise, in BrowserWithTestWindowTest,
    > it gets created twice: during test suite setup, and as part of
    > OzonePlatform (due to AshTestHelper/ash::Shell).
    >
    > Many tests still need one though, especially those that create a
    > WebContents, so add it to RenderViewHostTestEnabler, which should
    > take care of all RenderViewHostTestHarness tests or tests that create
    > the enabler manually.
    >
    > Also update a few other tests to either create their own
    > RenderViewHostTestEnabler or InputDeviceClient as appropriate.
    >
    > Also the InputDeviceManager can be a true singleton now (not thread-
    > singleton).
    
    TBR=sky@chromium.org
    
    Change-Id: I4eb8579404ab6c10fb9d6ac9ac8c8c6e7a9baa57
    Reviewed-on: https://chromium-review.googlesource.com/c/1352969
    Commit-Queue: Evan Stade <estade@chromium.org>
    Reviewed-by: default avatarEvan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#611837}
    59510e33
browser_with_test_window_test.h 7.59 KB