• Stephane Zermatten's avatar
    [Autofill Assistant] Fix the navigation detection logic. · 5963da8a
    Stephane Zermatten authored
    Before this patch, the navigation detection logic for what happens
    during a prompt (a script is running with a touchable element area) was
    incorrect:
     - it was too trigger happy, disallowing navigation for other frames,
       such when fetching data in the background
     - it did not detect usage of the back button
    
    With this patch, during a prompt, only non-renderer initiated navigation
    is disabled. That includes hitting the back button or refreshing the
    page through the UI, but not clicking on a link or Javascript-triggered
    navigation.
    
    From the user's point of view, with this patch, scripts won't randomly
    fail during prompt anymore.
    
    Change-Id: I0d825eeae596503e80d27e5ab032eee7e966ea4c
    Bug: 911108
    Reviewed-on: https://chromium-review.googlesource.com/c/1358496Reviewed-by: default avatarMathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#613101}
    5963da8a
controller.cc 19.7 KB