GitLab

This reverts commit aa74ca79.

Reason for revert:

Due to a bug in the original changelist, these histograms were never emitted.  In particular, they weren't emitted because the implementation classes (the ones that actually emit the metrics) aren't part of the class.  In other words, they're not overriding the parent class behavior and thus not getting called.

When I fixed the bug and tested the fix, I realized that the way I hooked up the metrics emitting code is wrong.  I expected the UnsentLogs.Sent-emitting code to be run only when persisted logs (logs from past sessions) were going to be sent.  However, it records all logs that are sent, not only persisted ones.  For example, it records (i) the initial stability log and (ii) the logs that happen at regular intervals.  Neither of those are counted in UnsentLogs.IntendingToSend.

Long story short: bug in original changelist.  Fixing the bug is non-trivial and requires substantial changes.  Reverting to start over fro a clean slate.

Reverting the histograms.xml change is safe because these histograms were never logged.

BUG=1148523

Original change's description:
> Add Metrics about Uploading UMA Records from Previous Sessions
>
> Change-Id: I908a337129062e882b185a08329fecfd7db6c496
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504593
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Mark Pearson <mpearson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#822037}

TBR=mpearson@chromium.org,holte@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ie44b8bac5948cb19af245800ac42e6b5bab11996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537604Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827872}