• Jérôme Lebel's avatar
    [iOS] Switching hosted domain from ChromeIdentity to ChromeIdentityService · 59e63f23
    Jérôme Lebel authored
    When sign-in with a new gmail account, the Chrome identity was
    initialized with no hosted domain since the SSO profile was not fetched
    yet.
    The property was never updated later. Even when the AuthenticationFlow
    was fetching hosted domain using the AuthenticationFlowPerformer.
    During the sign-in process
    
    To fix the issue, -ChromeIdentity.hostedDomain is remove. ChromeIdentity
    stays just a proxy for SSOIdentity.
    ChromeIdentityService::GetCachedHostedDomainForIdentity() is added to
    get the hosted domain.
    
    Bug introduced with:
      + crrev.com/c/1687254
      + crrev.com/i/1434627
      + crrev.com/c/1687254
    
    Related to:
      + crrev.com/c/1732084 (adding new API)
      + crrev.com/i/1560989 (adding new implementation)
      => crrev.com/c/1732085 (switching implementation) <=
      + crrev.com/i/1560990 (old implementation cleanup)
      + crrev.com/c/1732101 (cleanup API)
    
    Bug: 987380
    Change-Id: I658d3e0b109c68583db58b12a034de072adfc45f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732085
    Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
    Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: default avatarMihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#684155}
    59e63f23
BUILD.gn 1.34 KB