• Koji Ishii's avatar
    [LayoutNG] Include frame rect into visual rect for NGPhysicalTextFragment · 5a40ea25
    Koji Ishii authored
    This patch changes visual rect of NGPhysicalTextFragment to
    include its frame rect. Legacy does so, but NG did not when
    it was first implemented due to the lack of understanding.
    
    After reviewing test results, it turns out that by not doing
    so, background and decorations on space characters are
    affected by this difference because space characters do not
    have glyph bounding box, which results in empty visual rect.
    
    Includes rebaselines that improve the rendering.
    
    Bug: 636993, 714962
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: I888f8b27680aa1ff806cca15c84919461c06fc31
    Reviewed-on: https://chromium-review.googlesource.com/1027012Reviewed-by: default avatarAleks Totic <atotic@chromium.org>
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#553914}
    5a40ea25
TestExpectations 365 KB