• Stephane Zermatten's avatar
    [Autofill Assistant] Fail unknown actions instead of ignoring them. · 5ad19ef3
    Stephane Zermatten authored
    Before this patch, unknown action would be skipped and not reported to
    the server. This made it difficult to see what actions were unsupported.
    Also, this made the client mistakenly think that response with only
    unsupported action signalled the end of a script.
    
    This patch introduces an unknown action type, which always fail. This
    way, neither the client nor the developer will be confused by this case.
    
    This patch also transition UpdateProcessedAction from taking a boolean
    to taking a ProcessActionStatusProto, which lets us be more specific in
    what failed. I also left TODOs for the cases where we should be more
    specific and distinguish at least "element not found" from other errors.
    
    Bug: 806868
    Change-Id: I6efe1f2ac733f2048a5028c5ebb51fab2953868c
    Reviewed-on: https://chromium-review.googlesource.com/c/1257901
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: default avatarGanggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596653}
    5ad19ef3
click_action.cc 1.49 KB