• Ryan Hansberry's avatar
    [Nearby] Correct InstantMessaging metrics prefixes. · 5ae898e3
    Ryan Hansberry authored
    These metrics are currently prefixed with "Nearby.Share". Nearby Share
    is an application that depends on the Nearby Connections library. In
    reality, these metrics actually instrument an implementation of the
    Nearby Connections library, not an application like Nearby Share,
    and should instead be prefixed with "Nearby.Connections".
    
    This mistake was made because this logic resides in a 'nearby_sharing'
    directory, which is an unfortunate historical artifact. All of this
    logic needs to eventually be migrated to a more generic location,
    but more urgently, these metrics need to be migrated to their correct
    prefix.
    
    The previous metrics, prefixed with "Nearby.Share", have only been
    deployed to dev-channel, for a week, and will never be used, so I have
    not applied aa 'obsolete' label to them, opting instead to outright
    remove them.
    
    Bug: 1123172
    Change-Id: Ia22407469f4bc9a7f84813c17e37a5ce5d888624
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580907Reviewed-by: default avatarSteven Holte <holte@chromium.org>
    Reviewed-by: default avatarJosh Nohle <nohle@chromium.org>
    Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#835337}
    5ae898e3
receive_messages_express.cc 6.8 KB