GitLab

Despite what the current name implies, ComponentExtensionIMEManagerImpl
is NOT an implementation of ComponentExtensionIMEManager interface
(that's actually a concrete class, only ever subclassed by its mock).
This is extremely confusing in terms of readability.

In fact, ComponentExtensionIMEManagerImpl [sic] is an implementation
of ComponentExtensionIMEManagerDelegate interface. An instance of the
latter is dependency-injected for use by ComponentExtensionIMEManager
itself. The already confusing misnomer is thus exacerbated, as both
ComponentExtensionIMEManager and ComponentExtensionIMEManagerImpl [sic]
tend to appear together while bearing no inheritance relationship.

In this patch, ComponentExtensionIMEManagerImpl [sic] is renamed to
ComponentExtensionIMEManagerDelegateImpl to reflect what it really is.
Descriptiveness and conciseness improvements are out of scope.

Also:
- Extract ComponentExtensionIMEManagerDelegate to its own .h file.
- Fix pre-existing std::unique_ptr usage as flagged by presubmit errors.
- Replace pre-existing NULL with nullptr as flagged by presubmit errors.

Bug: 1134465
Change-Id: If36b7d4c17ee19cdfc773c22ad4f384779b2a4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440381
Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816644}